techdocsmith commented on a change in pull request #10880:
URL: https://github.com/apache/druid/pull/10880#discussion_r578050386
##########
File path: docs/configuration/index.md
##########
@@ -1644,7 +1644,8 @@ The Druid SQL server is configured through the following
properties on the Broke
|`druid.sql.enable`|Whether to enable SQL at all, including background
metadata fetching. If false, this overrides all other SQL-related properties
and disables SQL metadata, serving, and planning completely.|true|
|`druid.sql.avatica.enable`|Whether to enable JDBC querying at
`/druid/v2/sql/avatica/`.|true|
|`druid.sql.avatica.maxConnections`|Maximum number of open connections for the
Avatica server. These are not HTTP connections, but are logical client
connections that may span multiple HTTP connections.|25|
-|`druid.sql.avatica.maxRowsPerFrame`|Maximum number of rows to return in a
single JDBC frame. Setting this property to -1 indicates that no row limit
should be applied. Clients can optionally specify a row limit in their
requests; if a client specifies a row limit, the lesser value of the
client-provided limit and `maxRowsPerFrame` will be used.|5,000|
+|`druid.sql.avatica.maxRowsPerFrame`|Maximum value which can be supplied to
the JDBC `Statement.setFetchSize` method. This setting determines the maximum
sized JDBC `ResultSet` which Druid will populate in a single 'fetch'. Setting
this property to -1 indicates that no row limit should be applied on the
server-side, potentially returning the entire set of rows on the initial
statement execution. If the JDBC client calls `Statement.setFetchSize` with a
value other than -1, the lesser value of the client-provided limit and
`maxRowsPerFrame` will be used. If `maxRowsPerFrame` is smaller than
`minRowsPerFrame`, then the `ResultSet` size will be fixed. For handling
queries which produce results with a large number of rows, consider increasing
this value to reduce the number of fetches required to transfer the result
set.|5,000|
+|`druid.sql.avatica.minRowsPerFrame`|Minimum value which can be supplied to
the JDBC `Statement.setFetchSize` method. This property must be set to a value
greater than 0. If a `Statement.setFetchSize` is specified with a smaller
value, this row count will be used instead. If `maxRowsPerFrame` is set to a
value lower than `minRowsPerFrame`, the minimum value of the two will be used.
For handling queries which produce results with a large number of rows,
consider increasing this value to reduce the number of fetches required to
transfer the result set.|100|
Review comment:
```suggestion
|`druid.sql.avatica.minRowsPerFrame`|Minimum acceptable value for the JDBC
client `Statement.setFetchSize` method. The value for this property must
greater than 0. If the JDBC client specifies a `Statement.setFetchSize` with a
lesser value, Druid uses this row count instead. If `maxRowsPerFrame` is less
than `minRowsPerFrame`, Druid uses the minimum value of the two. For handling
queries which produce results with a large number of rows, you can increase
this value to reduce the number of fetches required to completely transfer the
result set.|100|
```
##########
File path: docs/configuration/index.md
##########
@@ -1644,7 +1644,8 @@ The Druid SQL server is configured through the following
properties on the Broke
|`druid.sql.enable`|Whether to enable SQL at all, including background
metadata fetching. If false, this overrides all other SQL-related properties
and disables SQL metadata, serving, and planning completely.|true|
|`druid.sql.avatica.enable`|Whether to enable JDBC querying at
`/druid/v2/sql/avatica/`.|true|
|`druid.sql.avatica.maxConnections`|Maximum number of open connections for the
Avatica server. These are not HTTP connections, but are logical client
connections that may span multiple HTTP connections.|25|
-|`druid.sql.avatica.maxRowsPerFrame`|Maximum number of rows to return in a
single JDBC frame. Setting this property to -1 indicates that no row limit
should be applied. Clients can optionally specify a row limit in their
requests; if a client specifies a row limit, the lesser value of the
client-provided limit and `maxRowsPerFrame` will be used.|5,000|
+|`druid.sql.avatica.maxRowsPerFrame`|Maximum value which can be supplied to
the JDBC `Statement.setFetchSize` method. This setting determines the maximum
sized JDBC `ResultSet` which Druid will populate in a single 'fetch'. Setting
this property to -1 indicates that no row limit should be applied on the
server-side, potentially returning the entire set of rows on the initial
statement execution. If the JDBC client calls `Statement.setFetchSize` with a
value other than -1, the lesser value of the client-provided limit and
`maxRowsPerFrame` will be used. If `maxRowsPerFrame` is smaller than
`minRowsPerFrame`, then the `ResultSet` size will be fixed. For handling
queries which produce results with a large number of rows, consider increasing
this value to reduce the number of fetches required to transfer the result
set.|5,000|
Review comment:
```suggestion
|`druid.sql.avatica.maxRowsPerFrame`|Maximum acceptable value for the JDBC
client `Statement.setFetchSize` method. This setting determines the maximum
number of rows that will Druid will populate in a single 'fetch' for a JDBC
`ResultSet`. Set this property to -1 to enforce no row limit on the
server-side and potentially return the entire set of rows on the initial
statement execution. If the JDBC client calls `Statement.setFetchSize` with a
value other than -1, Druid uses the lesser value of the client-provided limit
and `maxRowsPerFrame`. If `maxRowsPerFrame` is smaller than `minRowsPerFrame`,
then the `ResultSet` size will be fixed. To handle queries that produce results
with a large number of rows, you can increase value of
`druid.sql.avatica.maxRowsPerFrame` to reduce the number of fetches required to
completely transfer the result set.|5,000|
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
