suneet-s commented on a change in pull request #10956:
URL: https://github.com/apache/druid/pull/10956#discussion_r591971224
##########
File path:
server/src/test/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinatorTest.java
##########
@@ -848,6 +848,28 @@ public void testDeleteDataSourceMetadata() throws
IOException
Assert.assertNull("getDataSourceMetadataNullAfterDelete",
coordinator.retrieveDataSourceMetadata("fooDataSource"));
}
+ @Test
+ public void testDeleteSegments()
+ {
+ Exception e = null;
+ try {
+ coordinator.deleteSegments(SEGMENTS);
+ }
+ catch (Exception ex) {
+ e = ex;
+ }
+ Assert.assertNull(e);
Review comment:
If an exception is thrown, the test will fail. We don't need to catch
the exception and validate that it's null
```suggestion
coordinator.deleteSegments(SEGMENTS);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
