clintropolis commented on a change in pull request #10956:
URL: https://github.com/apache/druid/pull/10956#discussion_r592084345
##########
File path:
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
##########
@@ -1290,9 +1294,12 @@ public Void inTransaction(Handle handle,
TransactionStatus transactionStatus)
private void deleteSegment(final Handle handle, final DataSegment segment)
{
- handle.createStatement(StringUtils.format("DELETE from %s WHERE id = :id",
dbTables.getSegmentsTable()))
- .bind("id", segment.getId().toString())
- .execute();
+ String segmentsTable = dbTables.getSegmentsTable();
+ String segmentId = segment.getId().toString();
+ log.debug("Removing segment [%s] [%s] from Metadata Storage [%s]!",
segmentId, segment.getDataSource(), segmentsTable);
Review comment:
nit: I guess this could be a lot of segments, it might be nicer to pull
this outside of the loop and use `log.debugSegments`
##########
File path:
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
##########
@@ -1278,9 +1278,13 @@ public void deleteSegments(final Set<DataSegment>
segments)
@Override
public Void inTransaction(Handle handle, TransactionStatus
transactionStatus)
{
+ int segmentSize = segments.size();
+ String dataSource = "";
for (final DataSegment segment : segments) {
+ dataSource = segment.getDataSource();
deleteSegment(handle, segment);
}
+ log.info("Removed [%d] segments'metadata for dataSource [%s]!",
segmentSize, dataSource);
Review comment:
```suggestion
log.info("Removed [%d] segments from metadata for dataSource
[%s]!", segmentSize, dataSource);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
