zhangyue19921010 commented on a change in pull request #10956:
URL: https://github.com/apache/druid/pull/10956#discussion_r592124492
##########
File path:
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
##########
@@ -1290,9 +1294,12 @@ public Void inTransaction(Handle handle,
TransactionStatus transactionStatus)
private void deleteSegment(final Handle handle, final DataSegment segment)
{
- handle.createStatement(StringUtils.format("DELETE from %s WHERE id = :id",
dbTables.getSegmentsTable()))
- .bind("id", segment.getId().toString())
- .execute();
+ String segmentsTable = dbTables.getSegmentsTable();
+ String segmentId = segment.getId().toString();
+ log.debug("Removing segment [%s] [%s] from Metadata Storage [%s]!",
segmentId, segment.getDataSource(), segmentsTable);
Review comment:
Nice idea, I didn't notice there is `log.debugSegments` in druid before.
Changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
