zachjsh commented on a change in pull request #11075:
URL: https://github.com/apache/druid/pull/11075#discussion_r615152908
##########
File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/JobHelper.java
##########
@@ -482,20 +475,16 @@ public long push() throws IOException
.withSize(size.get())
.withBinaryVersion(SegmentUtils.getVersionFromDir(mergedBase));
- if (!renameIndexFiles(outputFS, tmpPath, finalIndexZipFilePath)) {
- throw new IOE(
- "Unable to rename [%s] to [%s]",
- tmpPath.toUri().toString(),
- finalIndexZipFilePath.toUri().toString()
- );
- }
-
- return finalSegment;
+ return new DataSegmentAndIndexZipFilePath(
+ finalSegment,
+ tmpPath.toUri().getPath(),
+ finalIndexZipFilePath.toUri().getPath()
+ );
}
public static void writeSegmentDescriptor(
Review comment:
Changed it so that the segment descriptor for a segment is not deleted,
and overwritten if it already exists, as we discussed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
