zachjsh commented on a change in pull request #11075:
URL: https://github.com/apache/druid/pull/11075#discussion_r611831329
##########
File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/JobHelper.java
##########
@@ -386,29 +386,13 @@ public static void writeJobIdToFile(String
hadoopJobIdFileName, String hadoopJob
}
}
- public static boolean runSingleJob(Jobby job, HadoopDruidIndexerConfig
config)
+ public static boolean runSingleJob(Jobby job)
{
boolean succeeded = job.run();
-
- if (!config.getSchema().getTuningConfig().isLeaveIntermediate()) {
Review comment:
Good catch! Fixed by adding a subsequent call to do cleanup in
HadoopDruidDetermineConfigurationJob. Also found another place in
CliInternalHadoopIndexer where we were maybe not doing necessary cleanup, and
fixed in similar way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
