zachjsh commented on a change in pull request #11075:
URL: https://github.com/apache/druid/pull/11075#discussion_r612151354
##########
File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/JobHelper.java
##########
@@ -482,20 +475,16 @@ public long push() throws IOException
.withSize(size.get())
.withBinaryVersion(SegmentUtils.getVersionFromDir(mergedBase));
- if (!renameIndexFiles(outputFS, tmpPath, finalIndexZipFilePath)) {
- throw new IOE(
- "Unable to rename [%s] to [%s]",
- tmpPath.toUri().toString(),
- finalIndexZipFilePath.toUri().toString()
- );
- }
-
- return finalSegment;
+ return new DataSegmentAndIndexZipFilePath(
+ finalSegment,
+ tmpPath.toUri().getPath(),
+ finalIndexZipFilePath.toUri().getPath()
+ );
}
public static void writeSegmentDescriptor(
Review comment:
We seem to be storing the information about the segments that we publish
in the descriptor file, and then read the data written to this this file /
directory in main task in order to know the list of segments that were
produced. If we dont create this file in the sub task / job, how will we know
what segments were created?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
