FrankChen021 commented on a change in pull request #10949:
URL: https://github.com/apache/druid/pull/10949#discussion_r618964596
##########
File path:
processing/src/test/java/org/apache/druid/query/aggregation/first/FloatFirstAggregationTest.java
##########
@@ -183,6 +201,40 @@ public void testSerde() throws Exception
Assert.assertEquals(floatFirstAggregatorFactory,
mapper.readValue(doubleSpecJson, AggregatorFactory.class));
}
+ @Test
+ public void testFloatFirstAggregateCombiner()
+ {
+ AggregateCombiner floatFirstAggregateCombiner =
combiningAggFactory.makeAggregateCombiner();
+
+ SerializablePair[] inputPairs = {
+ new SerializablePair<>(5L, 134.3f),
Review comment:
Sorry for the late response. null related tests have been added in the
latest commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]