FrankChen021 commented on a change in pull request #10949:
URL: https://github.com/apache/druid/pull/10949#discussion_r614506613
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/first/StringFirstLastUtils.java
##########
@@ -36,11 +36,16 @@
private static final int NULL_VALUE = -1;
/**
- * Returns whether a given value selector *might* contain
SerializablePairLongString objects.
Review comment:
Yes, `selectorNeedsFoldCheck` method in `StringFirstLastUtils` is now
shared by long/float/doubleFirst/Last, it should be extracted out of this
class.
I have not made more changes to this class file because stringFirst/Last
will be refactored in a new PR to share new abstract classes provided in this
PR, which means this class is also involved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
