clintropolis commented on a change in pull request #11293:
URL: https://github.com/apache/druid/pull/11293#discussion_r640485677



##########
File path: 
extensions-core/protobuf-extensions/src/main/java/org/apache/druid/data/input/protobuf/ProtobufInputRowParser.java
##########
@@ -89,11 +89,13 @@ public ProtobufInputRowParser withParseSpec(ParseSpec 
parseSpec)
       parser = parseSpec.makeParser();
     }
     Map<String, Object> record;
+    DateTime timestamp;
 
     if (parseSpec instanceof JSONParseSpec && ((JSONParseSpec) 
parseSpec).getFlattenSpec().getFields().isEmpty()) {
       try {
         DynamicMessage message = protobufBytesDecoder.parse(input);
         record = CollectionUtils.mapKeys(message.getAllFields(), k -> 
k.getJsonName());
+        timestamp = extractTimestampAsJson(record);

Review comment:
       Ah, i guess either disabling checking, or I assume its actually ok to do 
what i suspect was done the last time based on the look in the diff, that 
someone disregarded the instructions to not modify the generated code and it 
was just manually auto-formatted in intellij after it was generated heh




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to