clintropolis commented on a change in pull request #11293:
URL: https://github.com/apache/druid/pull/11293#discussion_r640487137
##########
File path:
extensions-core/protobuf-extensions/src/main/java/org/apache/druid/data/input/protobuf/ProtobufInputRowParser.java
##########
@@ -89,11 +89,13 @@ public ProtobufInputRowParser withParseSpec(ParseSpec
parseSpec)
parser = parseSpec.makeParser();
}
Map<String, Object> record;
+ DateTime timestamp;
if (parseSpec instanceof JSONParseSpec && ((JSONParseSpec)
parseSpec).getFlattenSpec().getFields().isEmpty()) {
try {
DynamicMessage message = protobufBytesDecoder.parse(input);
record = CollectionUtils.mapKeys(message.getAllFields(), k ->
k.getJsonName());
+ timestamp = extractTimestampAsJson(record);
Review comment:
intellij inspections is flagging a bunch of stuff on the generated file
too, hmm. trying to remember what happens if we just ignore it for now, if it
will keep complaining at us in future PRs or if it only flags new things...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
