clintropolis commented on a change in pull request #11280:
URL: https://github.com/apache/druid/pull/11280#discussion_r656999544
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/ExpressionLambdaAggregatorFactory.java
##########
@@ -121,6 +124,7 @@ public ExpressionLambdaAggregatorFactory(
this.initialValueExpressionString = initialValue;
this.initialCombineValueExpressionString = initialCombineValue == null ?
initialValue : initialCombineValue;
+ this.initiallyNull = initiallyNull == null ? NullHandling.sqlCompatible()
: initiallyNull;
Review comment:
renamed to `isNullUnlessAggregated` to more clearly indicate that it is
a boolean and hopefully indicate its main role in determining aggregator
behavior. `initiallyNull` seemed confusing alongside `initialValue`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
