rohangarg commented on a change in pull request #11280:
URL: https://github.com/apache/druid/pull/11280#discussion_r657163570
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/ExpressionLambdaAggregatorFactory.java
##########
@@ -195,6 +199,12 @@ public String getInitialCombineValueExpressionString()
return initialCombineValueExpressionString;
}
+ @JsonProperty("initiallyNull")
Review comment:
this should also be changed to `isNullUnlessAggregated`
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/ExpressionLambdaBufferAggregator.java
##########
@@ -21,73 +21,95 @@
import org.apache.druid.math.expr.Expr;
import org.apache.druid.math.expr.ExprEval;
+import org.apache.druid.math.expr.ExprType;
import javax.annotation.Nullable;
import java.nio.ByteBuffer;
public class ExpressionLambdaBufferAggregator implements BufferAggregator
{
+ private static final short NOT_AGGREGATED_BIT = 1 << 7;
+ private static final short IS_AGGREGATED_MASK = 0x3F;
+ private static final byte TYPE_MASK = 0x0F;
Review comment:
is it possible to drop either `TYPE_MASK` or `IS_AGGREGATED_MASK` and
use a common mask whose value is `0x0F` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
