jihoonson commented on a change in pull request #11474: URL: https://github.com/apache/druid/pull/11474#discussion_r674492345
########## File path: spark/src/main/scala/org/apache/druid/spark/configuration/Configuration.scala ########## @@ -0,0 +1,209 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.spark.configuration + +import org.apache.druid.java.util.common.StringUtils +import org.apache.spark.sql.sources.v2.DataSourceOptions + +import scala.collection.JavaConverters.mapAsScalaMapConverter + +/** + * A simple wrapper around a properties map that can also "dive" into a sub-Configuration if keys are stored using + * dotted separators. Because this class is designed to make working with Spark DataSourceOptions easier and DSOs are + * case-insensitive, this class is also case-insensitive. + * + * @param properties A Map of String property names to String property values to back this Configuration. + */ +class Configuration(properties: Map[String, String]) extends Serializable { Review comment: Perhaps the reason of using this class that you mentioned in the PR description would be worth to add here. ########## File path: spark/src/main/scala/org/apache/druid/spark/clients/DruidClient.scala ########## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.spark.clients + +import com.fasterxml.jackson.core.`type`.TypeReference +import com.google.common.net.HostAndPort +import org.apache.druid.java.util.common.{ISE, Intervals, JodaUtils, StringUtils} +import org.apache.druid.java.util.http.client.response.{StringFullResponseHandler, + StringFullResponseHolder} +import org.apache.druid.java.util.http.client.{HttpClient, Request} +import org.apache.druid.query.Druids +import org.apache.druid.query.metadata.metadata.{ColumnAnalysis, SegmentAnalysis, + SegmentMetadataQuery} +import org.apache.druid.spark.MAPPER +import org.apache.druid.spark.configuration.{Configuration, DruidConfigurationKeys} +import org.apache.druid.spark.mixins.Logging +import org.jboss.netty.handler.codec.http.{HttpMethod, HttpResponseStatus} +import org.joda.time.{Duration, Interval} + +import java.net.URL +import java.util.{List => JList} +import javax.ws.rs.core.MediaType +import scala.collection.JavaConverters.{asScalaBufferConverter, mapAsJavaMapConverter, + mapAsScalaMapConverter, seqAsJavaListConverter} + +/** + * Going with SegmentMetadataQueries despite the significant overhead because there's no other way Review comment: This is true. I think we should add a new datasources table in the system schema that provides all column information in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
