jihoonson commented on a change in pull request #11474:
URL: https://github.com/apache/druid/pull/11474#discussion_r674495036
##########
File path: LICENSE
##########
@@ -279,6 +279,13 @@ SOURCE/JAVA-CORE
This product contains lpad and rpad methods adapted from Apache Flink.
* core/src/main/java/org/apache/druid/java/util/common/StringUtils.java
+ This product contains Scala logging and serializable Hadoop configuration
utilities adapted from Apache Spark.
Review comment:
I forgot to mention about license and notice. Thank you for adding them!
This license and notice files are important for the release and must be
included in our release artifacts. I'm not sure how we are going to release
this spark extension yet, as it could be just a part of our regular release or
it could be released separately just like
[pydruid](https://github.com/druid-io/pydruid). So, this change LGTM for now,
but we may need to move this license and notice change to somewhere else later
depending on how we release this spark extension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
