techdocsmith commented on a change in pull request #11506: URL: https://github.com/apache/druid/pull/11506#discussion_r688035224
########## File path: docs/ingestion/native-batch.md ########## @@ -369,11 +369,16 @@ Druid currently supports only one partition function. The Parallel task will use one subtask when you set `maxNumConcurrentSubTasks` to 1. -> Be aware that, with this technique, segment sizes could be skewed if your chosen `partitionDimension` is also skewed in source data. - -> While it is technically possible to concatenate multiple dimensions into a single new dimension -> that you go on to specify in `partitionDimension`, remember that you _must_ then use this newly concatenated dimension at query time -> in order for segment pruning to be effective. +> When using this technique to partition your data, segment sizes may be unequally distributed if the data +> in your `partitionDimension` is also unequally distributed. Therefore, avoid imbalance in data layout and +> review the distribution of values in your source data before deciding on a partitioning strategy. + +> In order for segment pruning to be effective and translate into better query performance, you _must_ use +> the `partitionDimension` at query time. While it is possible to concatenate values from multiple +> dimensions into a single new dimension that you then opt to specify in `partitionDimension`, remember that you +> must use that new `partitionDimension` dimension in your +> [native filter](https://druid.apache.org/docs/latest/querying/filters.html) / Review comment: ```suggestion > [native filter](../querying/filters.md) / ``` Use the relative path to the `.md` for links ########## File path: docs/ingestion/native-batch.md ########## @@ -369,11 +369,16 @@ Druid currently supports only one partition function. The Parallel task will use one subtask when you set `maxNumConcurrentSubTasks` to 1. -> Be aware that, with this technique, segment sizes could be skewed if your chosen `partitionDimension` is also skewed in source data. - -> While it is technically possible to concatenate multiple dimensions into a single new dimension -> that you go on to specify in `partitionDimension`, remember that you _must_ then use this newly concatenated dimension at query time -> in order for segment pruning to be effective. +> When using this technique to partition your data, segment sizes may be unequally distributed if the data +> in your `partitionDimension` is also unequally distributed. Therefore, avoid imbalance in data layout and +> review the distribution of values in your source data before deciding on a partitioning strategy. + +> In order for segment pruning to be effective and translate into better query performance, you _must_ use +> the `partitionDimension` at query time. While it is possible to concatenate values from multiple Review comment: ```suggestion > the `partitionDimension` at query time. You can concatenate values from multiple ``` ########## File path: docs/ingestion/native-batch.md ########## @@ -369,11 +369,16 @@ Druid currently supports only one partition function. The Parallel task will use one subtask when you set `maxNumConcurrentSubTasks` to 1. -> Be aware that, with this technique, segment sizes could be skewed if your chosen `partitionDimension` is also skewed in source data. - -> While it is technically possible to concatenate multiple dimensions into a single new dimension -> that you go on to specify in `partitionDimension`, remember that you _must_ then use this newly concatenated dimension at query time -> in order for segment pruning to be effective. +> When using this technique to partition your data, segment sizes may be unequally distributed if the data +> in your `partitionDimension` is also unequally distributed. Therefore, avoid imbalance in data layout and +> review the distribution of values in your source data before deciding on a partitioning strategy. + +> In order for segment pruning to be effective and translate into better query performance, you _must_ use +> the `partitionDimension` at query time. While it is possible to concatenate values from multiple +> dimensions into a single new dimension that you then opt to specify in `partitionDimension`, remember that you Review comment: ```suggestion > dimensions into a new dimension to use as the `partitionDimension`. In this case, you ``` ########## File path: docs/ingestion/native-batch.md ########## @@ -369,11 +369,16 @@ Druid currently supports only one partition function. The Parallel task will use one subtask when you set `maxNumConcurrentSubTasks` to 1. -> Be aware that, with this technique, segment sizes could be skewed if your chosen `partitionDimension` is also skewed in source data. - -> While it is technically possible to concatenate multiple dimensions into a single new dimension -> that you go on to specify in `partitionDimension`, remember that you _must_ then use this newly concatenated dimension at query time -> in order for segment pruning to be effective. +> When using this technique to partition your data, segment sizes may be unequally distributed if the data +> in your `partitionDimension` is also unequally distributed. Therefore, avoid imbalance in data layout and +> review the distribution of values in your source data before deciding on a partitioning strategy. + +> In order for segment pruning to be effective and translate into better query performance, you _must_ use +> the `partitionDimension` at query time. While it is possible to concatenate values from multiple +> dimensions into a single new dimension that you then opt to specify in `partitionDimension`, remember that you +> must use that new `partitionDimension` dimension in your +> [native filter](https://druid.apache.org/docs/latest/querying/filters.html) / +> [WHERE clause](https://druid.apache.org/docs/latest/querying/sql.html#where). Review comment: ```suggestion > [WHERE clause](../querying/sql.md#where). ``` Is this link necessary? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
