loquisgon commented on a change in pull request #11536:
URL: https://github.com/apache/druid/pull/11536#discussion_r703932161
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/config/TaskConfig.java
##########
@@ -117,7 +131,19 @@ public TaskConfig(
this.shuffleDataLocations = shuffleDataLocations;
}
this.ignoreTimestampSpecForDruidInputSource =
ignoreTimestampSpecForDruidInputSource;
- this.useLegacyBatchProcessing = useLegacyBatchProcessing;
+
+ this.batchMemoryMappedIndex = batchMemoryMappedIndex;
+ // Conflict resolution. Assume that if batchMemoryMappedIndex is set
(since false is the default) that
+ // the user changed it intentionally to use legacy, in this case oveeride
batchProcessingMode and also
+ // set it to legacy else just use batchProcessingMode and don't pay
attention to batchMemoryMappedIndexMode:
+ if (batchMemoryMappedIndex) {
+ this.batchProcessingMode = BatchProcesingMode.LEGACY;
+ } else if (EnumUtils.isValidEnum(BatchProcesingMode.class,
batchProcesingMode)) {
+ this.batchProcessingMode =
BatchProcesingMode.valueOf(batchProcesingMode);
+ } else {
+ // batchProcessingMode input string is invalid, just use the
default...log message somewhere???
+ this.batchProcessingMode = BatchProcesingMode.CLOSED_SEGMENTS; // Default
+ }
Review comment:
yeah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
