FrankChen021 commented on a change in pull request #11723:
URL: https://github.com/apache/druid/pull/11723#discussion_r716017391
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamSamplerSpec.java
##########
@@ -92,9 +93,22 @@ public SamplerResponse sample()
);
inputFormat = null;
} else {
+ RecordSupplier<PartitionIdType, SequenceOffsetType, RecordType>
recordSupplier;
+
+ try {
+ recordSupplier = createRecordSupplier();
+ }
+ catch (Exception e) {
Review comment:
There're also other code that throw SamplerException, so I think
`SamplerExceptionMapper` is a good place to handle the exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
