cryptoe commented on a change in pull request #11723:
URL: https://github.com/apache/druid/pull/11723#discussion_r728867499
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamSamplerSpec.java
##########
@@ -92,9 +93,22 @@ public SamplerResponse sample()
);
inputFormat = null;
} else {
+ RecordSupplier<PartitionIdType, SequenceOffsetType, RecordType>
recordSupplier;
+
+ try {
+ recordSupplier = createRecordSupplier();
+ }
+ catch (Exception e) {
+ if (e.getCause() != null) {
+ throw new SamplerException(e, "Unable to sample data: %s. Cause:
%s", e.getMessage(), e.getCause().getMessage());
Review comment:
Nit: Can we change it to say 'unable to create Record Supplier' as this
call starts a kakfa/kinessis consumer which can fail due to N reasons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
