FrankChen021 opened a new pull request #11723:
URL: https://github.com/apache/druid/pull/11723


   Fixes #11651 
   
   ### Description
   
   This PR improves the exception message when using the web console wizard to 
load data by:
   1. catching exception that is thrown when constructing kafka consumer object 
and then re-throwing a SamplerException which will be automatically mapped to a 
JSON object by existing `SamplerExceptionMapper`
   
   2. since `SamplerExceptionMapper` returns the exception message to the 
client without any stack trace, it's not able to know where the exception comes 
from, so we also loges the cause of SamplerException to log so that we know 
where the exception is thrown from server side log
   
   Now the web-console showes the error as followes:
   
![image](https://user-images.githubusercontent.com/6525742/133927769-9988e63b-7958-45d5-a74e-5065d36e4100.png)
   
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not 
all of these items apply to every PR. Remove the items which are not done or 
not relevant to the PR. None of the items from the checklist below are strictly 
necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   - [X] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [X] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [X] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to