clintropolis commented on a change in pull request #11961:
URL: https://github.com/apache/druid/pull/11961#discussion_r764479194
##########
File path:
extensions-core/protobuf-extensions/src/main/java/org/apache/druid/data/input/protobuf/FileBasedProtobufBytesDecoder.java
##########
@@ -98,35 +98,40 @@ public DynamicMessage parse(ByteBuffer bytes)
url = new URL(descriptorFilePath);
}
catch (MalformedURLException e) {
- throw new ParseException(e, "Descriptor not found in class path or
malformed URL:" + descriptorFilePath);
+ throw new ParseException(
+ descriptorFilePath,
Review comment:
nit: descriptorFilePath (and some of the other things passed into the
input argument in various places) don't really seem to be stringified input,
should these that don't have the actual row be using `null` here instead?
##########
File path:
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/data/input/kafkainput/KafkaInputReader.java
##########
@@ -104,7 +104,10 @@ public KafkaInputReader(
valueRow = (MapBasedInputRow) r;
}
catch (ClassCastException e) {
- throw new ParseException("Unsupported input format in valueFormat.
KafkaInputformat only supports input format that return MapBasedInputRow rows");
+ throw new ParseException(
+ null,
+ "Unsupported input format in valueFormat. KafkaInputformat
only supports input format that return MapBasedInputRow rows"
Review comment:
nit: `KafkaInputFormat`
##########
File path:
core/src/main/java/org/apache/druid/data/input/impl/MapInputRowParser.java
##########
@@ -107,13 +108,15 @@ static InputRow parse(
}
if (timestamp == null) {
throw new ParseException(
+ rawMapToPrint(theMap),
Review comment:
nit, should this re-use `rawMapToPrint` output instead of calling
multiple times?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
