abhishekagarwal87 commented on a change in pull request #11961:
URL: https://github.com/apache/druid/pull/11961#discussion_r764693180
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskClient.java
##########
@@ -243,11 +247,16 @@ public DateTime getStartTime(final String id)
null,
true
);
- return response.getContent() == null || response.getContent().isEmpty()
- ? Collections.emptyList()
- : deserialize(response.getContent(),
TYPE_REFERENCE_LIST_PARSE_EXCEPTION_REPORT);
+
+ if (response.getContent() == null || response.getContent().isEmpty()) {
+ log.warn("Got empty response when calling getParseErrors, id[%s]", id);
+ return Collections.emptyList();
+ }
+
+ return deserialize(response.getContent(),
TYPE_REFERENCE_LIST_PARSE_EXCEPTION_REPORT);
}
catch (NoTaskLocationException e) {
+ log.warn(e,"Got NoTaskLocationException when calling getParseErrors,
id[%s]", id);
Review comment:
this might be failing build because of missing space after comma
##########
File path:
core/src/main/java/org/apache/druid/java/util/common/parsers/ParseException.java
##########
@@ -37,27 +39,56 @@
*/
public class ParseException extends RuntimeException
{
+ /**
+ * If true, the row was partiall parseable, but some columns could not be
parsed
Review comment:
```suggestion
* If true, the row was partially parseable, but some columns could not be
parsed
```
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
##########
@@ -1153,6 +1210,26 @@ public Boolean isHealthy()
}
}
+ @Override
+ public List<ParseExceptionReport> getParseErrors()
+ {
+ try {
+ if
(spec.getSpec().getTuningConfig().convertToTaskTuningConfig().getMaxParseExceptions()
<= 0) {
+ return ImmutableList.of();
+ }
+ lastKnownParseErrors = getCurrentParseErrors();
+ return lastKnownParseErrors;
+ }
+ catch (InterruptedException ie) {
+ Thread.currentThread().interrupt();
+ log.error(ie, "getCurrentParseErrors() interrupted.");
Review comment:
this could be warn since it will likely be logged during shutdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
