jasonk000 edited a comment on pull request #12097: URL: https://github.com/apache/druid/pull/12097#issuecomment-1000674887
Some extra data, .. With reference to the TaskQueue-Manager thread, a capture with info enabled:  With respect to this thread only, the `TaskRunner::shutdown` call is 82% of CPU in the `manage()` loop, and, the useful part of the loop, `findWorkerRunningTask` consumes ~18%, the rest is logging related. By (1) turning off INFO logging on this path, and (2) avoiding the `StringUtils.format()` call, we get approx 4x more capacity through the `TaskQueue-Manager` thread.  <hr> ie: If you take the image just above ^, and eliminate the `Logger::info` and `StringUtils::format` paths, it opens a lot of capacity through this loop. This becomes more obvious when coupled to #12096 and the yet-to-be-raised PR to reduce contention on the TaskQueue loop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
