FrankChen021 commented on a change in pull request #12097:
URL: https://github.com/apache/druid/pull/12097#discussion_r775688676
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskRunner.java
##########
@@ -88,11 +89,17 @@
*/
void shutdown(String taskid, String reason);
- default void shutdown(String taskid, String reasonFormat, Object... args)
+ default void shutdown(String taskid, String reasonFormat, Object...
reasonArgs)
{
- shutdown(taskid, StringUtils.format(reasonFormat, args));
+ String reason = (getLogger().isInfoEnabled()) ?
StringUtils.format(reasonFormat, reasonArgs) : null;
Review comment:
better to add some comments here to elaborate why we do this here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
