jasonk000 commented on pull request #12097:
URL: https://github.com/apache/druid/pull/12097#issuecomment-1001778350
Capturing some test case results from #12099 we have more concrete example:
Alternating between these two lines:
```
default void shutdown(String taskid, String reasonFormat, Object...
reasonArgs)
{
// String reason = (getLogger().isInfoEnabled()) ?
StringUtils.format(reasonFormat, reasonArgs) : null;
String reason = StringUtils.format(reasonFormat, reasonArgs);
shutdown(taskid, reason);
}
```
The existing approach to always format the message completes the
TaskQueueScaleTest in 15.x seconds:
```
[INFO] Running org.apache.druid.indexing.overlord.TaskQueueScaleTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
15.553 s - in org.apache.druid.indexing.overlord.TaskQueueScaleTest
```
Using the new way to only format if necessary completes the test in 6.x
seconds:
```
[INFO] Running org.apache.druid.indexing.overlord.TaskQueueScaleTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.529
s - in org.apache.druid.indexing.overlord.TaskQueueScaleTest
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
