FrankChen021 commented on a change in pull request #12105:
URL: https://github.com/apache/druid/pull/12105#discussion_r776539164
##########
File path:
processing/src/main/java/org/apache/druid/segment/StringDimensionIndexer.java
##########
@@ -132,8 +132,10 @@ public long estimateEncodedKeyComponentSize(int[] key)
// even though they are stored just once. It may overestimate the size by
a bit, but we wanted to leave
// more buffer to be safe
long estimatedSize = key.length * Integer.BYTES;
- for (int element : key) {
Review comment:
nit: it's better to rename the original variable name `key` to `keys` to
make it intuitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
