FrankChen021 commented on a change in pull request #12105:
URL: https://github.com/apache/druid/pull/12105#discussion_r776549385
##########
File path:
processing/src/main/java/org/apache/druid/segment/DimensionDictionary.java
##########
@@ -84,6 +84,19 @@ public T getValue(int id)
}
}
+ public void getValuesInto(int[] ids, T[] values)
+ {
+ lock.readLock().lock();
+ try {
+ for (int i = 0; i < ids.length; i++) {
Review comment:
Yes, handling generic in java is a little complicated. How about using
`List<T>` as the returning type? This won't introduce any magic code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
