FrankChen021 commented on pull request #12105: URL: https://github.com/apache/druid/pull/12105#issuecomment-1003242678
> while we are here, could you share an opinion on this implementation, it's faster again but with a different API: [jasonk000@f4354bb](https://github.com/jasonk000/druid/commit/f4354bbe8ccaed556c0488bc875d753afabc1b86) -> https://github.com/jasonk000/druid/pull/8/files As a public API that accepts a callback, I'm worried about if user provides a time-consuming callback, which means the read lock will be held for a long time, and the write lock will be blocked. So I think current solution in this PR might be better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
