kfaraz commented on a change in pull request #12073:
URL: https://github.com/apache/druid/pull/12073#discussion_r782358233
##########
File path:
processing/src/main/java/org/apache/druid/segment/incremental/OnheapIncrementalIndex.java
##########
@@ -265,11 +306,12 @@ private void doAggregate(
{
rowContainer.set(row);
+ long totalIncrementalBytes = 0L;
for (int i = 0; i < aggs.length; i++) {
final Aggregator agg = aggs[i];
synchronized (agg) {
try {
- agg.aggregate();
+ totalIncrementalBytes += agg.aggregateWithSize();
Review comment:
Fixed.
##########
File path:
processing/src/main/java/org/apache/druid/segment/incremental/OnheapIncrementalIndex.java
##########
@@ -240,22 +257,46 @@ public int getLastRowIndex()
return indexIncrement.get() - 1;
}
- private void factorizeAggs(
+ /**
+ * Creates aggregators for the given aggregator factories.
+ *
+ * @return Total initial size in bytes required by all the aggregators.
+ * This value is non-zero only when {@link #useMaxMemoryEstimates} is false.
+ */
+ private long factorizeAggs(
AggregatorFactory[] metrics,
Aggregator[] aggs,
ThreadLocal<InputRow> rowContainer,
InputRow row
)
{
+ long totalInitialSizeBytes = 0L;
rowContainer.set(row);
for (int i = 0; i < metrics.length; i++) {
final AggregatorFactory agg = metrics[i];
- aggs[i] = agg.factorize(selectors.get(agg.getName()));
+
+ if (useMaxMemoryEstimates) {
+ aggs[i] = agg.factorize(selectors.get(agg.getName()));
+ } else {
+ SizedAggregator sizedAggregator =
+ agg.factorizeSized(selectors.get(agg.getName()));
+ aggs[i] = sizedAggregator.getAggregator();
+ totalInitialSizeBytes += sizedAggregator.getInitialSizeBytes();
+ }
}
rowContainer.set(null);
+
+ return useMaxMemoryEstimates ? 0 : totalInitialSizeBytes;
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
