imply-cheddar commented on a change in pull request #12073:
URL: https://github.com/apache/druid/pull/12073#discussion_r782717538
##########
File path:
processing/src/main/java/org/apache/druid/segment/incremental/IncrementalIndex.java
##########
@@ -478,6 +479,11 @@ public IncrementalIndexAddResult add(InputRow row) throws
IndexSizeExceededExcep
return add(row, false);
}
+ public IncrementalIndexAddResult add(InputRow row, boolean
skipMaxRowsInMemoryCheck) throws IndexSizeExceededException
+ {
+ return add(row, false, true);
Review comment:
This appears to be ignoring `skipMaxRowsInMemoryCheck` is that
intentional? Probably worth a comment as to why that's intentional if it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
