kfaraz commented on a change in pull request #12073:
URL: https://github.com/apache/druid/pull/12073#discussion_r783080415
##########
File path:
server/src/main/java/org/apache/druid/segment/realtime/plumber/RealtimePlumber.java
##########
@@ -271,6 +271,7 @@ private Sink getSink(long timestamp)
config.getAppendableIndexSpec(),
config.getMaxRowsInMemory(),
config.getMaxBytesInMemoryOrDefault(),
+ true,
Review comment:
The value of the flag `useMaxMemoryEstimates = true` represents old
behaviour.
The hard coding has been done only for the following classes:
- `RealtimePlumber` and related classes (hopefully not used anymore)
- `OnHeapIncrementalIndexBenchmark` (accidentally hardcoded to false, fixing
this)
It should NOT be hardcoded to false in any of these cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
