jihoonson edited a comment on pull request #12158: URL: https://github.com/apache/druid/pull/12158#issuecomment-1013743797
Forgot to mention, thank you for creating labels that could be useful for classifying and searching for PRs. However, `maven` doesn't seem accurate for this PR because it's not really about maven, but CI. Also, I think labels should be general enough because having a large number of labels does not help with either classifying PRs or searching for PRs. It will rather increase the maintenance cost for labels. I don't think I remember all labels we have today. If all those labels are legit and reasonable, then we should document them. However, I don't think all of them are worth to document because many of them are specialized for particular topics. For example, I see labels of "Apache Pulsar", "Apache Spark", "Apache RocketMQ", and "Apache Avatica". Do we really need all these labels? How many PRs have been being created for each topic? To me, they have a very narrow scope of topic. "Apache Pulsar", "Apache Spark", and "Apache RocketMQ" can be just one label "extension" or "ecosystem". "Apache Avatica" should be "JDBC". This is why we have instructions documented for [creating a new label on GitHub](https://github.com/apache/druid/blob/master/dev/committer-instructions.md#creating- a-new-label-on-github). These instructions explicitly say that you should be able to find at least 3 PRs that are relevant to the new label. This implies that the new label should be general enough to be applied to multiple PRs. The instructions also say that you have to update the doc for labels and announce the new label you created, so that other committers can be aware of the new label and what it is for. Please follow these instructions when you create a label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
