jihoonson commented on pull request #12158: URL: https://github.com/apache/druid/pull/12158#issuecomment-1013810124
> LGTM seems unstable, and I tried to restart it and it seems not work. It's not LGTM being unstable. LGTM was trying to run the forbidden API check against the master branch without your change in this PR which must fail. That's why it never passed. But now other PRs seem to be passing LGTM after this PR is merged which is expected. I'm not sure why LGTM was building the master branch though. Maybe we should fix the LGTM script or configuration. > However, I also passed the test locally, so the PR should be OK. The entire project shares the same Token instead of multi tokens for each one, so there should be no permission issues, right. In the long term, we can use Github Action to trigger instead to ensure the stability of the CI process. Anyway, I'll go check it out recently. I'm not sure if you understand me correctly. I'm not talking about flaky tests. I'm talking about Travis not running for the PRs you create or the master branch after you merge a PR into it. This seems important as we don't want to skip relevant CI in Travis in any case after the master branch is updated. I'm not entirely sure what's the issue. I'm just guessing it could be a permission issue because that's what I see in Travis as seen in [my previous comment](https://github.com/apache/druid/pull/12158#issuecomment-1013740883). Please contact the ASF infra team as soon as possible and fix it first whatever the issue is _before you merge any PRs_. > About the label part, I got your point, SGTM. However, I remember that the maven label was not created by me. If you think it is unsuitable, please feel free to delete it. In addition to labels you mentioned, there are Kubernetes and Helm labels. If they are too detailed, please also feel free to delete them. So, I don't know what you had in mind when you create those labels. My point is, please share your thought for those labels when you create them. And this is all what our instructions say too. For example, why do we need the "Kubernetes" label? I know it can be added to PRs that are related to k8s. My question is what is the use of this label? How do you use it? Your intention about this should be shared with other developers. This is also why I'm asking you to document those labels you created with your intention together. So, let me clarify my thought again here. I'm not saying "don't create labels". What I mean is, you can create whatever labels you want, but please share with other developers what label you created and how we can use it. If someone disagrees with you, then we can discuss. But we should first know why you created the label before we discuss. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
