asdf2014 commented on pull request #12158: URL: https://github.com/apache/druid/pull/12158#issuecomment-1013804139
Hi @jihoonson , thanks for your comments, and you are welcome. Yes, the LGTM seems unstable, and I tried to restart it and it seems not work. And after you merged this PR to master branch, the status of CI shows pending but actually the job of CI already completed successfully, which is odd, we can get the details from the log of the job of CI. However, I also passed the test locally, so the PR should be OK. The entire project shares the same Token instead of multi tokens for each one, so there should be no permission issues, right. In the long term, we can use Github Action to trigger instead to ensure the stability of the CI process. Anyway, I'll go check it out recently.   About the label part, I got your point, SGTM. However, I remember that the `maven` label was not created by me. If you think it is unsuitable, please feel free to delete it. In addition to labels you mentioned, there are `Kubernetes` and `Helm` labels. If they are too detailed, please also feel free to delete them. BTW, this blocker problem caused by third-part maven plugin, so I just [report](https://github.com/policeman-tools/forbidden-apis/pull/164#issuecomment-1013803286) this to the author of the `forbiddenapis` maven plugin. Hope we can get some answers soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
