kfaraz commented on a change in pull request #12073:
URL: https://github.com/apache/druid/pull/12073#discussion_r785662541
##########
File path:
processing/src/main/java/org/apache/druid/segment/DimensionDictionary.java
##########
@@ -160,4 +173,16 @@ public int getIdForNull()
lock.readLock().unlock();
}
}
+
+ private long getObjectSize(@Nonnull T object)
Review comment:
Used the `StringDimensionDictionary` suggestion, although I have not
made it abstract so that implementations using the `DimensionDictionary` can
continue to use it as the base concrete class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
