kfaraz commented on a change in pull request #12073:
URL: https://github.com/apache/druid/pull/12073#discussion_r783081365
##########
File path:
processing/src/main/java/org/apache/druid/segment/incremental/IncrementalIndex.java
##########
@@ -557,12 +573,17 @@ IncrementalIndexRowResult toIncrementalIndexRow(InputRow
row)
DimensionIndexer indexer = desc.getIndexer();
Object dimsKey = null;
try {
- dimsKey =
indexer.processRowValsToUnsortedEncodedKeyComponent(row.getRaw(dimension),
true);
+ final EncodedDimensionValue<?> encodedDimensionValue
+ =
indexer.processRowValsToUnsortedEncodedKeyComponent(row.getRaw(dimension),
true);
Review comment:
Yes, I was not too sure about this either. I will take another look and
see if we can separate the two flows without too much duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
