TSFenwick commented on a change in pull request #12207:
URL: https://github.com/apache/druid/pull/12207#discussion_r799028936
##########
File path:
extensions-contrib/aliyun-oss-extensions/src/main/java/org/apache/druid/storage/aliyun/OssStorageDruidModule.java
##########
@@ -103,4 +105,11 @@ public OSS initializeOssClient(OssClientConfig
inputSourceConfig)
{
return inputSourceConfig.buildClient();
}
+
+ @Provides
+ @LazySingleton
+ public Supplier<OSS> initializeOssClientSupplier(OssClientConfig
inputSourceConfig)
+ {
+ return Suppliers.memoize(inputSourceConfig::buildClient);
Review comment:
nit: I think leaving a comment here would help people understand that
this is lazily supplied to avoid needing to set unnecessary properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
