jihoonson opened a new pull request #12207:
URL: https://github.com/apache/druid/pull/12207
### Description
Currently, the ingestion task requires for you to specify the AWS region if
you have `druid-s3-extensions` loaded _even when your ingestion task doesn't
use s3_. This is because `OmniDataSegment` tools are being initialized when the
Peon starts up which loads all implementations from extensions. This is a bug
from UX perspective as the the user should be able to specify AWS region only
when they use s3. This PR fixes `OmniDataSegment` tools to initialize
implementations lazily, so that ingestion jobs can run without requiring
unnecessary AWS region. The ingestion job now will fail when it tries to use
any of those tools if something is not configured properly instead of at the
beginning of the ingestion job. This change is covered by integration tests as
ingestion tests always use the kill task to clean up segments in deep storage
after the test is done.
<hr>
##### Key changed/added classes in this PR
* `MyFoo`
* `OurBar`
* `TheirBaz`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
- [x] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
