TSFenwick commented on a change in pull request #12207:
URL: https://github.com/apache/druid/pull/12207#discussion_r799029663
##########
File path:
extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureStorageDruidModule.java
##########
@@ -117,25 +119,30 @@ public void configure(Binder binder)
@Provides
@LazySingleton
- public CloudBlobClient getCloudBlobClient(final AzureAccountConfig config)
- throws URISyntaxException, InvalidKeyException
+ public Supplier<CloudBlobClient> getCloudBlobClient(final AzureAccountConfig
config)
Review comment:
like previously mentioned
nit: I think leaving a comment here would help people understand that this
is lazily supplied to avoid needing to set unnecessary properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
