clintropolis commented on pull request #12241: URL: https://github.com/apache/druid/pull/12241#issuecomment-1033351418
> Did you consider something that is an actual expression tree? the string fragments generated here do later turn into `Expr`, which is the AST of native expressions, however that is a bit more work than I was trying to bite off at this time, and we lack JSON serialization and such to be able to send these expressions parsed over the wire. It is probably worth considering doing this at some point, but for now I focused on changing as little as possible to allow the transformations I needed, which is just to swap complete operations. Additionally, `Expr` is missing a lot of information that we might want to decorate it with if we were using it in this manner, so we would need some additional adjustments to use like this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
