clintropolis commented on a change in pull request #12241:
URL: https://github.com/apache/druid/pull/12241#discussion_r802303270
##########
File path:
extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/quantiles/sql/DoublesSketchSqlAggregatorTest.java
##########
@@ -564,7 +564,7 @@ public void testDoublesSketchPostAggs() throws Exception
),
new ExpressionPostAggregator(
"p3",
- "(p2 + 1000)",
+ "(\"p2\" + 1000)",
Review comment:
no, I think it was potentially a bug that the identifiers were not
always being escaped in expression post-aggs, that has been fixed by the
changes in how we build the native string expressions. humans are still allowed
to reference identifiers without the double quotes, just the expressions we
generate from SQL will always be escaped with them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
