imply-cheddar commented on a change in pull request #12241:
URL: https://github.com/apache/druid/pull/12241#discussion_r802316191
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/rel/VirtualColumnRegistry.java
##########
@@ -41,29 +44,33 @@
*/
public class VirtualColumnRegistry
{
+ private final ExprMacroTable macroTable;
private final RowSignature baseRowSignature;
- private final Map<ExpressionWrapper, VirtualColumn>
virtualColumnsByExpression;
- private final Map<String, VirtualColumn> virtualColumnsByName;
+ private final Map<ExpressionAndTypeHint, String> virtualColumnsByExpression;
+ private final Map<String, ExpressionAndTypeHint> virtualColumnsByName;
private final String virtualColumnPrefix;
private int virtualColumnCounter;
private VirtualColumnRegistry(
RowSignature baseRowSignature,
+ ExprMacroTable macroTable,
String virtualColumnPrefix,
- Map<ExpressionWrapper, VirtualColumn> virtualColumnsByExpression,
- Map<String, VirtualColumn> virtualColumnsByName
+ Map<ExpressionAndTypeHint, String> virtualColumnsByExpression,
+ Map<String, ExpressionAndTypeHint> virtualColumnsByName
)
{
+ this.macroTable = macroTable;
this.baseRowSignature = baseRowSignature;
this.virtualColumnPrefix = virtualColumnPrefix;
this.virtualColumnsByExpression = virtualColumnsByExpression;
this.virtualColumnsByName = virtualColumnsByName;
}
- public static VirtualColumnRegistry create(final RowSignature rowSignature)
Review comment:
Agree that it's pretty in the weeds and someone who actually depends on
the implementation to this level is probably in deep enough to deal with the
change. Documenting seems reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
