jihoonson opened a new pull request #12276:
URL: https://github.com/apache/druid/pull/12276
### Description
Today, `dimensionsSpec` has two modes with `flattenSpec` as below.
1) If `dimensions` is set in `dimensionsSpec`, only those explicit
dimensions are ingested.
2) If `dimensions is not set, all dimensions that `flattenSpec` provides are
ingested.
However, there is a missing use case that I want to ingest both the
dimensions in `dimensionsSpec` and other dimensions discovered using
`flattenSpec` during ingestion. To address this, this PR adds a new flag,
`includeAllDimensions` in `dimensionsSpec`. `MapInputRowParser` will put all
explicit dimensions first in `InputRow` and then any other dimensions found in
input data.
<hr>
##### Key changed/added classes in this PR
* `DimensionsSpec`
* `MapInputRowParser`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
- [x] added documentation for new or modified features or behaviors.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
