jihoonson commented on a change in pull request #12276:
URL: https://github.com/apache/druid/pull/12276#discussion_r813394227
##########
File path:
indexing-service/src/test/java/org/apache/druid/indexing/firehose/IngestSegmentFirehoseFactoryTimelineTest.java
##########
@@ -91,9 +91,7 @@
new JSONParseSpec(
new TimestampSpec(TIME_COLUMN, "auto", null),
new DimensionsSpec(
- DimensionsSpec.getDefaultSchemas(Arrays.asList(DIMENSIONS)),
Review comment:
I could have done it, but added something similar for the builder
instead (`Builder.setDefaultSchemaDimensions()`) to encourage people to use the
builder instead. Does this make sense to you?
##########
File path:
core/src/main/java/org/apache/druid/data/input/impl/DimensionsSpec.java
##########
@@ -69,11 +71,22 @@ public static DimensionSchema
convertSpatialSchema(SpatialDimensionSchema spatia
return new NewSpatialDimensionSchema(spatialSchema.getDimName(),
spatialSchema.getDims());
}
+ public static Builder builder()
+ {
+ return new Builder();
+ }
+
+ public DimensionsSpec(List<DimensionSchema> dimensions)
+ {
+ this(dimensions, null, null, false);
+ }
+
@JsonCreator
- public DimensionsSpec(
+ private DimensionsSpec(
@JsonProperty("dimensions") List<DimensionSchema> dimensions,
@JsonProperty("dimensionExclusions") List<String> dimensionExclusions,
- @Deprecated @JsonProperty("spatialDimensions")
List<SpatialDimensionSchema> spatialDimensions
+ @Deprecated @JsonProperty("spatialDimensions")
List<SpatialDimensionSchema> spatialDimensions,
+ @JsonProperty("includeAllDimensions") boolean includeAllDimensions
Review comment:
`boolean` variables are initialized to false when they are missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
