jihoonson commented on a change in pull request #12276:
URL: https://github.com/apache/druid/pull/12276#discussion_r813393990
##########
File path:
core/src/test/java/org/apache/druid/data/input/impl/MapInputRowParserTest.java
##########
@@ -31,28 +30,27 @@
import org.junit.Test;
import org.junit.rules.ExpectedException;
-import java.util.List;
-import java.util.Set;
-
public class MapInputRowParserTest
{
@Rule
public ExpectedException expectedException = ExpectedException.none();
private final TimestampSpec timestampSpec = new TimestampSpec("time", null,
null);
- private final List<String> dimensions = ImmutableList.of("dim");
- private final Set<String> dimensionExclusions = ImmutableSet.of();
Review comment:
The behavior hasn't changed. I made the test more realistic since the
timestamp field name is always in `dimensionExclusions` in production. See
https://github.com/apache/druid/blob/master/server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java#L162-L177.
##########
File path:
core/src/main/java/org/apache/druid/data/input/impl/MapInputRowParser.java
##########
@@ -69,29 +66,32 @@ public static InputRow parse(InputRowSchema inputRowSchema,
Map<String, Object>
return parse(inputRowSchema.getTimestampSpec(),
inputRowSchema.getDimensionsSpec(), theMap);
}
- private static InputRow parse(
- TimestampSpec timestampSpec,
+ private static List<String> findDimensions(
Review comment:
I added a javadoc and renamed `theMap` to `rawInputRow`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
