machine424 commented on pull request #12271: URL: https://github.com/apache/druid/pull/12271#issuecomment-1055280863
Hi @kfaraz, Thanks for your response. I maybe misspoke, but we retrieve the timeout from the response context here: https://github.com/apache/druid/blob/3f709db173d779db1466e57a1564a5f557b4b0cf/processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java#L75 we check it here: https://github.com/apache/druid/blob/3f709db173d779db1466e57a1564a5f557b4b0cf/processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java#L174-L176 And we alter it (in the response context) here: https://github.com/apache/druid/blob/3f709db173d779db1466e57a1564a5f557b4b0cf/processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java#L188-L192 (Of course the compiler wouldn't have appreciated altering an immutable field ^^) And I did test the changes, as I said in https://github.com/apache/druid/issues/12197#issuecomment-1025143613: > ...After commenting out Lines 190 to 194, the query's timeout (As I understand it) seems to be respected. Of course it's always possible to exceed it (while in rowsToList for example if the batchSize is big) but this is another subject which is discussed in https://github.com/apache/druid/issues/1415. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
