machine424 commented on PR #12271: URL: https://github.com/apache/druid/pull/12271#issuecomment-1128657661
Thanks @gianm for your review, done. I also squashed. Yep, maybe the original logic has changed but not everywhere in the code (didn't dig in the history too much). There is another timeout `QUERY_FAIL_TIME` that is redefined from the same timeout query attribute I think. https://github.com/apache/druid/blob/0fd4f1e3863f8f33bec69fc77dcb1ea118a42ed4/server/src/main/java/org/apache/druid/server/SetAndVerifyContextQueryRunner.java#L69-L73 I'll see if we can just use `ResponseContext.Key.TIMEOUT_AT`. I know you're all busy and that 3 months is not that much (I've a MR that has been hanging for 15 months on another repo :)) but how could we give these fix PR more exposure? (I've tried slack and the mailing list in vain, but I think you saw my last message on slack), -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
