machine424 commented on PR #12271: URL: https://github.com/apache/druid/pull/12271#issuecomment-1153823711
> We wouldn't use it there, since TIMEOUT_AT is a Scan query thing. I meant we define two timeouts in the code from same `timeout` query attribute. Maybe there is some refactoring to be done. > Excellent question. It's up to the community collectively to review and merge patches in a timely manner. Of course only committers can merge patches, but anyone can review, and that does help. In fact reviewing the work of others is one way to earn the merit needed to become a committer. >I don't recognize your github handle, but if you're not already a committer & you're interested in getting more involved then keep at it and become part of the solution 😀 Thanks, I don't have much time for now for reviewing, but I'll not skimp on patches if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
