clintropolis commented on a change in pull request #12314:
URL: https://github.com/apache/druid/pull/12314#discussion_r821182357
##########
File path:
processing/src/main/java/org/apache/druid/segment/filter/cnf/HiveCnfHelper.java
##########
@@ -178,6 +179,11 @@ private static void generateAllCombinations(
a.add(child);
// Result must receive an actual OrFilter.
result.add(idempotentOr(Filters.or(a)));
+ if (result.size() >= 10_000) {
Review comment:
any reason for this limit to be configurable?
##########
File path:
processing/src/main/java/org/apache/druid/segment/filter/cnf/CNFFilterExplosionException.java
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.segment.filter.cnf;
+
+import org.apache.druid.java.util.common.StringUtils;
+
+public class CNFFilterExplosionException extends Exception
Review comment:
should this be a `BadQueryException`? Since i think this is user
controllable by setting a context flag or not, I think doing this would result
in it being a user error when it eventually surfaces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
