rohangarg commented on a change in pull request #12314:
URL: https://github.com/apache/druid/pull/12314#discussion_r821447587
##########
File path:
processing/src/main/java/org/apache/druid/segment/filter/cnf/HiveCnfHelper.java
##########
@@ -178,6 +179,11 @@ private static void generateAllCombinations(
a.add(child);
// Result must receive an actual OrFilter.
result.add(idempotentOr(Filters.or(a)));
+ if (result.size() >= 10_000) {
Review comment:
I've added the change where exceeding this limit for not fail queries
for now. when the limit exceeds, the join flow will disable pushdown
optimization and the normal filter flow will return the non-CNF filter. does
that seem ok to not add a config to toggle the limit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
